Remove redundant call to SetFree for objects bigger than 4GB - #119930
Closed
Alikhalesi wants to merge 2 commits into
Closed
Remove redundant call to SetFree for objects bigger than 4GB#119930Alikhalesi wants to merge 2 commits into
Alikhalesi wants to merge 2 commits into
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
Author
@dotnet-policy-service agree |
This was referenced Sep 20, 2025
jkotas
reviewed
Sep 22, 2025
|
|
||
| #ifdef HOST_64BIT | ||
| #ifndef HOST_64BIT | ||
| ((CObjectHeader*)x)->SetFree(size); |
Member
There was a problem hiding this comment.
Suggested change
| ((CObjectHeader*)x)->SetFree(size); | |
| ((CObjectHeader*)x)->SetFree(size); |
Indentation is off (applies to the rest of the code as well)
jkotas
reviewed
Sep 22, 2025
| size_t current_size = UINT32_MAX - get_alignment_constant (FALSE) | ||
| - Align (min_obj_size, get_alignment_constant (FALSE)); | ||
|
|
||
| *(((PTR_PTR)tmp)-1) = 0; |
Member
There was a problem hiding this comment.
Is it really necessary to clear these interim syncblocks? Can we keep "Also clear the syncblock" before #ifndef HOST_64BIT and delete it here?
Contributor
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #119424